Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace golint with revive #572

Merged
merged 2 commits into from
Aug 8, 2022
Merged

Replace golint with revive #572

merged 2 commits into from
Aug 8, 2022

Conversation

praveenrewar
Copy link
Member

@praveenrewar praveenrewar commented Aug 7, 2022

What this PR does / why we need it:

Replace golint with revive
Fixes the warning:

WARN [runner] The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner.  Replaced by revive.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?


Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


WARN [runner] The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner.  Replaced by revive.
@praveenrewar praveenrewar requested a review from a team August 7, 2022 18:44
Copy link
Contributor

@100mik 100mik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than one mall change! Looks like the other tools have already picked this up 🚀

(revive is a dramatic name though. Love it xD)

@cppforlife cppforlife merged commit 7db695d into develop Aug 8, 2022
@praveenrewar praveenrewar deleted the replace-golint branch September 21, 2022 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants