Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Release Automation #443

Merged
merged 3 commits into from
Feb 28, 2022
Merged

Fixed Release Automation #443

merged 3 commits into from
Feb 28, 2022

Conversation

rohitagg2020
Copy link
Contributor

@rohitagg2020 rohitagg2020 commented Feb 23, 2022 •
edited
Loading

Fixed Release Automation

  • Added checksum.
  • Added post Release workflow as well.
  • Moved back from goreleaser to uploading the binaries by script as we faced issue with goreleaser earlier. The checksum calculated and uploaded by goreleaser were different.

@rohitagg2020
Fixed Release Automation
c0f7b4b 
Fixed Release Automation
joaopapereira
joaopapereira reviewed Feb 23, 2022
View reviewed changes
Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment about the steps I feel like are not needed due to ylls release process

praveenrewar
praveenrewar reviewed Feb 25, 2022
View reviewed changes
praveenrewar
praveenrewar approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

100mik
100mik approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@100mik 100mik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rohitagg2020 rohitagg2020 merged commit c9a4d21 into develop Feb 28, 2022
@rohitagg2020 rohitagg2020 deleted the release-automation branch March 7, 2022 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaopapereira joaopapereira joaopapereira left review comments

@praveenrewar praveenrewar praveenrewar approved these changes

@100mik 100mik 100mik approved these changes

@renuy renuy Awaiting requested review from renuy

@sethiyash sethiyash Awaiting requested review from sethiyash

@kumaritanushree kumaritanushree Awaiting requested review from kumaritanushree

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rohitagg2020 @joaopapereira @praveenrewar @100mik @vmwclabot