Don't panic on error in rebaseRule provided by user #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100mik
requested changes
Dec 8, 2021
User can provide rebaseRule with `{allIndexes: true}` as last element , which is not supported and should generate error message.
Other panics in this file left as is, because when these are more like asserts, indicating bug in the code when triggered.
github-actions
bot
added
the
carvel triage
|
@redbaron, VMware has approved your signed contributor license agreement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User can provide rebaseRule with
{allIndexes: true}as last element , which is not supported and should generate error message.Other panics in this file left as is, because when these are more like asserts, indicating bug in the code when triggered.