Supplement hack/gen-crds.sh with overlay for internalpackagemetadata #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhelfand
force-pushed
the
crd_overlay
branch
3 times, most recently
from
453c81b
to
3707e2a
Compare
cppforlife
reviewed
Jun 15, 2021
cppforlife
reviewed
Jun 15, 2021
danielhelfand
force-pushed
the
crd_overlay
branch
from
3707e2a
to
df891c5
Compare
ewrenn8
reviewed
Jun 15, 2021
danielhelfand
force-pushed
the
crd_overlay
branch
from
f5768a3
to
ba5995f
Compare
cppforlife
reviewed
Jun 15, 2021
danielhelfand
force-pushed
the
crd_overlay
branch
from
ba5995f
to
fa92d59
Compare
cppforlife
reviewed
Jun 16, 2021
danielhelfand
force-pushed
the
crd_overlay
branch
from
fa92d59
to
a30fd2d
Compare
cppforlife
reviewed
Jun 16, 2021
cppforlife
reviewed
Jun 16, 2021
danielhelfand
force-pushed
the
crd_overlay
branch
from
a30fd2d
to
f7828f7
Compare
Since the autogenerated clients use internalpackagemetadatas as plural, crds need s added to be consistent.
danielhelfand
force-pushed
the
crd_overlay
branch
4 times, most recently
from
7475af6
to
b50a829
Compare
cppforlife
reviewed
Jun 16, 2021
danielhelfand
force-pushed
the
crd_overlay
branch
8 times, most recently
from
60bb8c2
to
211465d
Compare
danielhelfand
force-pushed
the
crd_overlay
branch
12 times, most recently
from
61eef95
to
43ced0a
Compare
danielhelfand
force-pushed
the
crd_overlay
branch
from
43ced0a
to
5ee72de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the autogenerated clients use internalpackagemetadatas as plural, crds need s added to be consistent.
By default,
controller-genhasinternalpackagemetadataas the plural name of the CRD so this preserves the automation of the script.