-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update-kind-example-to-containerd_1.5 #1483
base: develop
Are you sure you want to change the base?
fix: update-kind-example-to-containerd_1.5 #1483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the contribution. Could you please sign your commits to make the DCO bot happy, we can merge the PR then.
aaa63b5
to
6174e8c
Compare
…troller-sidecarexec containers Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com> Signed-off-by: dmitrynovik <dmitry.novik@gmail.com>
…d. Add wait flags to pkg i pause. Signed-off-by: Soumik Majumder <soumikm@vmware.com> Signed-off-by: dmitrynovik <dmitry.novik@gmail.com>
column will be visible when --wide flag is set to true Signed-off-by: Premkumar Bhaskal <pbhaskal@gmail.com> Signed-off-by: dmitrynovik <dmitry.novik@gmail.com>
Signed-off-by: dmitrynovik <dmitry.novik@gmail.com>
Signed-off-by: dmitrynovik <dmitry.novik@gmail.com>
Signed-off-by: dmitrynovik <dmitry.novik@gmail.com>
6174e8c
to
c8e3018
Compare
@dmitrynovik I think the rebase didn't work so there are some commits coming up from develop. Could you please take a look at it? |
What this PR does / why we need it:
Adjusted the example of running the
kapp-controller
inkind
for thecontainerd 1.5+
The example supplied in this repository, kapp-controller in kind, no longer works with my
containerd://1.7.1
- the pods are scheduled and created, but there are image pull errors as every pod tries to pull image over HTTPS instead of HTTP ( as in this StackOverflow example).I believe this change happened in containerd v1.5 as each container needs a
hosts.toml
file.This new requirement is also reflected in project kind: create a local registry, note a new step which is missing in the 2 year old kind-with-registry.sh script:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?
NONE
-->
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: