Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround for windows for SystemCertPool utility #463

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

Vandy-P
Copy link

@Vandy-P Vandy-P commented Dec 13, 2022

Signed-off-by: Vandana Pathak pathakv@sjc-ubu-eng-127.vmware.com

Fixes #462

Signed-off-by: Vandana Pathak <pathakv@sjc-ubu-eng-127.vmware.com>
Signed-off-by: Vandana Pathak <pathakv@sjc-ubu-eng-127.vmware.com>
@Vandy-P Vandy-P had a problem deploying to TanzuNet Registry Dev e2e December 13, 2022 19:34 — with GitHub Actions Failure
@Vandy-P Vandy-P temporarily deployed to TanzuNet Registry Dev e2e December 13, 2022 19:36 — with GitHub Actions Inactive
@Vandy-P Vandy-P temporarily deployed to GCR e2e December 13, 2022 19:36 — with GitHub Actions Inactive
Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaopapereira joaopapereira merged commit 8089d99 into carvel-dev:develop Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In registry.go, newHTTPTransport function still uses workaround for windows for SystemCertPool utility
3 participants