-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate messages for Copy and Push options regarding lock output flag #377
Separate messages for Copy and Push options regarding lock output flag #377
Conversation
It seems that the linter does not like the exported methods (even though the Also, the performance test is .8 seconds slower, but I haven't changed anything about that. |
When you create new public functions you need to add a comment. |
It seems there was a problem reading the images to copy: Also, other test shows that we are too slow by 0.2 seconds: |
After a rerun, the only failing test is the performance one. As we haven't changed behavior, should we modify the failing threshold? or does it merit investigation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@vicmarbev I created this issue #380 to track the investigation and eventually take some measures to save some of this information in order to understand in the future if we see degradation with time or not. Nevertheless, I will merge your PR. |
This PR is a response to issue #354. Different functions to create the Cobra flag for
push
andcopy
commands, each one with its own text.