Skip to content

Commit

Permalink
Fix z-index issue with tooltip content (#851)
Browse files Browse the repository at this point in the history
  • Loading branch information
JunichiSugiura authored Oct 11, 2024
1 parent a426b3a commit 0e2adfe
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 14 deletions.
2 changes: 1 addition & 1 deletion packages/profile/src/components/navigation.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ function Item({
/>
</div>
</TooltipTrigger>
<TooltipContent side="bottom">
<TooltipContent>
<p className="capitalize">{variant}</p>
</TooltipContent>
</Tooltip>
Expand Down
2 changes: 1 addition & 1 deletion packages/ui-next/src/components/network.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export function Network({ chainId }: { chainId: string }) {
<div>{getChainName(chainId)}</div>
</Button>
</TooltipTrigger>
<TooltipContent side="bottom" className="bg-background">
<TooltipContent>
<div>{hexToString(chainId as Hex)}</div>
</TooltipContent>
</Tooltip>
Expand Down
35 changes: 23 additions & 12 deletions packages/ui-next/src/components/primitives/tooltip.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,15 @@ import * as React from "react";
import * as TooltipPrimitive from "@radix-ui/react-tooltip";

import { cn } from "@/utils";
import { createPortal } from "react-dom";

const TooltipProvider = TooltipPrimitive.Provider;
const TooltipProvider = ({
delayDuration = 0,
...props
}: React.ComponentProps<typeof TooltipPrimitive.Provider>) => (
<TooltipPrimitive.Provider delayDuration={delayDuration} {...props} />
);
TooltipProvider.displayName = TooltipPrimitive.Provider.displayName;

const Tooltip = TooltipPrimitive.Root;

Expand All @@ -14,17 +21,21 @@ const TooltipTrigger = TooltipPrimitive.Trigger;
const TooltipContent = React.forwardRef<
React.ElementRef<typeof TooltipPrimitive.Content>,
React.ComponentPropsWithoutRef<typeof TooltipPrimitive.Content>
>(({ className, sideOffset = 4, ...props }, ref) => (
<TooltipPrimitive.Content
ref={ref}
sideOffset={sideOffset}
className={cn(
"z-50 overflow-hidden rounded-md bg-secondary px-3 py-1.5 text-xs text-secondary-foreground animate-in fade-in-0 zoom-in-95 data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=closed]:zoom-out-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2",
className,
)}
{...props}
/>
));
>(({ className, sideOffset = 4, side = "bottom", ...props }, ref) =>
createPortal(
<TooltipPrimitive.Content
ref={ref}
sideOffset={sideOffset}
side={side}
className={cn(
"z-50 overflow-hidden rounded-md bg-background px-3 py-1.5 text-xs text-secondary-foreground animate-in fade-in-0 zoom-in-95 data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=closed]:zoom-out-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2 delay-0 duration-75",
className,
)}
{...props}
/>,
document.body,
),
);
TooltipContent.displayName = TooltipPrimitive.Content.displayName;

export { Tooltip, TooltipTrigger, TooltipContent, TooltipProvider };

0 comments on commit 0e2adfe

Please sign in to comment.