Fast follow of #1429: fix typo in version specifier #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a misplaced single quote.
achantavy
changed the title
achantavy
changed the title
kunaals
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a misplaced single quote.
Before:
We set
VERSION_SPECIFIER='=='${{ env.VERSION }}, and this evaluates to'=='0.98.0rc2.Instead, we need it to evaluate to
'==0.98.0rc2'.After:
I can't test this in github actions unless this is merged and deployed, but I tried to test locally:
This PR moves the
'character to what I think is the correct place for the version specifier string to be interpreted correctly by pip.