Skip to content

Commit

Permalink
1.0.0 (#4)
Browse files Browse the repository at this point in the history
* fixes effects due to form & common module merge

* removes configuration module dependency

* adds module dependency

* bumps package version (#3)
  • Loading branch information
smurtazakazmi authored Oct 22, 2023
1 parent 1d7e61f commit 9840444
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 16 deletions.
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{
"name": "@cartesianui/bo-user",
"version": "0.1.0",
"version": "1.0.0",
"peerDependencies": {
"@angular/common": "^16.2.2",
"@angular/core": "^16.2.2",
"@angular/forms": "^16.2.2",
"@cartesianui/core": "^1.0.1",
"@cartesianui/common": "^0.1.0",
"@cartesianui/forms": "^0.1.0"
"@cartesianui/core": "^2.0.0",
"@cartesianui/common": "^1.0.0",
"@cartesianui/bo-auth": "^1.0.0"
},
"dependencies": {
"tslib": "^2.4.0"
Expand Down
20 changes: 10 additions & 10 deletions src/lib/ui/configuration/user-configuration.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Component, OnInit } from '@angular/core';
import { Injector, OnDestroy } from '@angular/core';
import { FormControl, FormGroup, Validators } from '@angular/forms';
import { BaseComponent } from '@cartesianui/common';
import { Configuration, ConfigurationSandbox } from '@cartesianui/bo-configuration';
// import { Configuration, ConfigurationSandbox } from '@cartesianui/bo-configuration';

@Component({
selector: 'user-configuration',
Expand All @@ -25,11 +25,11 @@ export class UserConfigurationComponent extends BaseComponent implements OnInit,
loading: boolean;
loaded: boolean;
failed: boolean;
configuration: Configuration;
// configuration: Configuration;

constructor(
injector: Injector,
protected _sandbox: ConfigurationSandbox
// protected _sandbox: ConfigurationSandbox
) {
super(injector);
}
Expand All @@ -41,13 +41,13 @@ export class UserConfigurationComponent extends BaseComponent implements OnInit,

update() {
const configurations = this.formGroup.value;
const form = new Configuration({
id: this.configuration.id,
key: 'user',
configuration: configurations
});
// const form = new Configuration({
// id: this.configuration.id,
// key: 'user',
// configuration: configurations
// });

this._sandbox.updateConfiguration(form);
// this._sandbox.updateConfiguration(form);
}

addSubscriptions() {
Expand All @@ -63,7 +63,7 @@ export class UserConfigurationComponent extends BaseComponent implements OnInit,
}

fetchConfiguration() {
this._sandbox.fetchConfigurationByType('user');
// this._sandbox.fetchConfigurationByType('user');
}

getFormClasses(controlName: string): string {
Expand Down
2 changes: 0 additions & 2 deletions src/lib/user.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import { TypeaheadModule } from 'ngx-bootstrap/typeahead';
import { NgxDatatableModule } from '@swimlane/ngx-datatable';
import { BsDatepickerModule } from 'ngx-bootstrap/datepicker';
import { CommonModule as CartesianCommonModule } from '@cartesianui/common';
import { FormsModule as CartesianFormModule } from '@cartesianui/forms';
import { BoLayoutModule } from '@cartesianui/coreui';
import { AuthModule } from '@cartesianui/bo-auth';

Expand All @@ -35,7 +34,6 @@ import { UserConfigurationComponent } from './ui/configuration/user-configuratio
FormsModule,
ReactiveFormsModule,
CartesianCommonModule.forFeature(),
CartesianFormModule.forFeature(),
BoLayoutModule.forFeature(),
UserRoutingModule,
BsDropdownModule.forRoot(),
Expand Down

0 comments on commit 9840444

Please sign in to comment.