Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use square bracket syntax for array destructuring #495

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Use square bracket syntax for array destructuring #495

merged 1 commit into from
Sep 10, 2019

Conversation

8633brown
Copy link
Contributor

No description provided.

@brunogaspar brunogaspar changed the title remove list function for new square brackets Use square bracket syntax for array destructuring Sep 10, 2019
@brunogaspar brunogaspar merged commit 4851e13 into cartalyst:master Sep 10, 2019
@brunogaspar
Copy link
Member

Nice one @8633brown , i tend to forget about this feature :)

@8633brown
Copy link
Contributor Author

@brunogaspar sorry about this i'm terrible at remembering to run composer cs:fix turns out you guys hve cs fixer setup to expand these out.
https://github.com/cartalyst/php-cs-fixer-config/blob/1ee153df72a79d71e459e398de1a6d26f1fd3e36/src/Config.php#L35

@8633brown 8633brown deleted the list branch September 10, 2019 05:52
@8633brown 8633brown restored the list branch September 10, 2019 05:52
@brunogaspar
Copy link
Member

Ya, that's correct.

Probably better to keep it that way, as it's consistent every where, will run it locally.

@8633brown 8633brown deleted the list branch September 10, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@8633brown @brunogaspar