fix files in new tab bug #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
VaiTon
reviewed
Oct 7, 2023
Comment on lines
+23
to
+31
| {#if $settings.newTab} | ||
| <a class="link link-hover text-primary" href="{$page.url}/{data.name}" target="_blank" rel="noreferrer"> | ||
| {data.name} | ||
| </a> | ||
| {:else} | ||
| <a class="link link-hover text-primary" href="{$page.url}/{data.name}"> | ||
| {data.name} | ||
| </a> | ||
| {/if} |
There was a problem hiding this comment.
Instead of this if else you can just do
target={$settings.newTab ? "_blank" : null}
and same for rel
There was a problem hiding this comment.
Please run prettier format on this file
A quale bug ti riferisci? Btw esisteva già una PR sul newTab.. #104 |
|
@Bitrey non è la stessa di #104 ? |
|
Confermo, colpa mia che non avevo guardato |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep track of whether to open files in a new tab or not (in $settings), and fix the open in new tab bug