Finish App #35
Finish App #35
Conversation
…oller Scaffold recipe and user
Registration with devise
There was a problem hiding this comment.
Hi team 👋
Good job so far!
There are some issues that you still need to work on but you are almost there!
Highlights
- Nice UI 👍
- Registration and login implemented with devise 👍
- Database schema matches the ERD provided 👍
- Users can add recipes and foods and can make recipes public or private 👍
- Associations between models were made correctly 👍
Required Changes ♻️
Check the comments under the review.
Optional suggestions
N/A
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
app/views/recipes/show.html.erb
Outdated
| <p class="recipeDescription"><%= @recipe.description %></p> | ||
| <%if recipe_author?(@recipe.user)%> | ||
| <button ><%= link_to "Generate Shopping List", shopping_list_path %></button> | ||
| <button id="addIngredientButton">Add Ingredient</button> |
There was a problem hiding this comment.
As mentioned in the requirements, this button should lead to the form to create a new food if the user is the owner of the recipe.
| <p class="cookingTime"><strong>Cooking Time: </strong> <%= @recipe.cooking_time_minutes %></p> | ||
| <p class="recipeDescription"><%= @recipe.description %></p> | ||
| <%if recipe_author?(@recipe.user)%> | ||
| <button ><%= link_to "Generate Shopping List", shopping_list_path %></button> |
There was a problem hiding this comment.
When accessing a public recipe, the user should be able to generate a shopping list even if they're not the owner of the recipe. So this button should be visible for all users.
…edient button for recipe owner
Make generate shopping list available for public recipes and add ingr…
There was a problem hiding this comment.
Hi @carreraprogrammer ,
Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
Highlights
✔️ Professional Readme file 👍
✔️ Good commit history 👍
✔️ No linter error 👍
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
There was a problem hiding this comment.
Hi @carreraprogrammer and @Cisco-the-wayword ,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
✔️ Professional Readme file 👍
✔️ Good commit history 👍
✔️ No linter error 👍
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
4 participants
RAILS GROUP PROJECT
Hello, I hope you are doing well !! ✋
For this project, we created a recipes app following the next requirements:
Happy Coding !! 🚀 🔥
Grabacion.de.pantalla.desde.12-08-23.19.12.31.webm