Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add survey links to instructor profile #2359

Merged
merged 5 commits into from
Mar 15, 2023

Conversation

elichad
Copy link
Contributor

@elichad elichad commented Mar 10, 2023

Fixes #2016 .

I used the instructor_pre field, but we could also use the reports_link function to generate the URL on the fly. I chose the former as some events don't seem to have survey links at all (especially older ones) and some point to surveymonkey links. Any thoughts on this?

Side question though: how/when is instructor_pre actually set? I assumed it's automatic if we can generate the links automatically, but I can't find it in the code.

@pbanaszkiewicz
Copy link
Contributor

@elichad According to documentation, instructors_pre is not used, but I can see it appears on EventForm, probably editable by the user. @maneesha can you confirm that?

@elichad
Copy link
Contributor Author

elichad commented Mar 14, 2023

Confirmed in a meeting with @maneesha that we are actively using instructors_pre as part of the Event form. I've updated the documentation accordingly.

@elichad elichad merged commit bdf9994 into develop Mar 15, 2023
@elichad elichad deleted the feature/2016-survey-links-in-profile branch March 15, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include survey links in instructor profile view
2 participants