-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-name columns named "start" and "end" #1807
Comments
A migration and possibly quite some changes in templates required. |
as start and end are SQL reserved word. carpentries#1807
…dels as start/end are reserved SQL words. carpentries#1807
We had a community member create a PR long ago that I closed becuase I didn't think the PR does everything it needs to, and would be reluctant to merge it as it would break many of our external queries. It makes writing SQL queries a bit annoying as we have to do something to escape the reserved words. I'm not sure if this could potentially cause other problems as well, so I would defer to @elichad and @pbanaszkiewicz on what to do next. |
I think we can make this change, it's just a matter of finding all the places that use the old names and updating them. @maneesha Feel free to add this to the next milestone. |
Note: we now have other models with these fields too, for example |
Two tables in AMY use
start
andend
as a column name. Sinceend
is also a PostgreSQL reserved word andstart
is a SQL reserved word, it causes problems when running SQL queries. SQLite was more forgiving, but as PostgreSQL is stricter, this should be fixed, renamingstart
andend
tostart_date
andend_date
.Tables with
start
andend
columns:The text was updated successfully, but these errors were encountered: