Add shim to enable remotes (<= 2.5.0) support for ubuntu 24.04#101
Merged
froggleston merged 1 commit intocarpentries:mainfrom Mar 28, 2025
Merged
Add shim to enable remotes (<= 2.5.0) support for ubuntu 24.04#101froggleston merged 1 commit intocarpentries:mainfrom
froggleston merged 1 commit intocarpentries:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ubuntu 22.04 has been present in the official remotes version for 3 years now so it's probably safe to drop the hack for it here.
However, support for ubuntu 24.04 has not yet landed in the released version of remotes (see r-lib/remotes#826) so I'm re-using the code already present to offer in the meantime.
Another alternative could be to drop this entire code chunk and add the remotes dev version to the Carpentries r-universe to get support for ubuntu 24.04 through "official" means.