Skip to content

Ntfy.sh Internationalized URL support added for click= #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2025

Conversation

caronc
Copy link
Owner

@caronc caronc commented Mar 30, 2025

Description:

Related issue (if applicable): #1308

Support ntfy.sh internationalized URLs

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@1308-escape-ntfy-click

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
   "ntfys://ntfy.sh/topic/?click=https://通知の例"

@caronc caronc linked an issue Mar 30, 2025 that may be closed by this pull request
Copy link

codecov bot commented Mar 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.37%. Comparing base (689fc07) to head (f80a6f2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1312   +/-   ##
=======================================
  Coverage   99.37%   99.37%           
=======================================
  Files         161      161           
  Lines       21068    21069    +1     
  Branches     3790     3791    +1     
=======================================
+ Hits        20937    20938    +1     
  Misses        121      121           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@caronc caronc merged commit 3151877 into master Mar 30, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ntfy request headers containing unicode are not escaped
1 participant