Add renderer argument to render() method of BooleanWidget
#923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #923 +/- ##
=======================================
Coverage 98.32% 98.32%
=======================================
Files 15 15
Lines 1197 1197
=======================================
Hits 1177 1177
Misses 20 20
Continue to review full report at Codecov.
|
@bronsen I guess that's because we don't use the other affected widgets ( |
|
So it would make sense to modify the other widgets as well. Good, I shall do so! |
This ought to help against: > .../lib/python3.6/site-packages/django/forms/boundfield.py:36: > RemovedInDjango21Warning: Add the `renderer` argument to the render() method > of <class 'django_filters.widgets.BooleanWidget'>. It will be mandatory in > Django 2.1. The renderer argument was added in Django 1.11: https://docs.djangoproject.com/en/2.0/ref/forms/widgets/#django.forms.Widget.render
This is then passed on to the super() call and also the render() call of the `surrogate`: it's a TextInput and hence a Widget as well.
carltongibson
force-pushed
the
avoid-deprecation
branch
from
84f4934
to
77ea984
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ought to help against:
The renderer argument was added in Django 1.11: https://docs.djangoproject.com/en/2.0/ref/forms/widgets/#django.forms.Widget.render
I have seen this deprecation warning only in association with the BooleanWidget, so only this class was modified.