Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra forward slash #50

Merged
merged 1 commit into from
Mar 1, 2025
Merged

Remove extra forward slash #50

merged 1 commit into from
Mar 1, 2025

Conversation

iamfil
Copy link
Contributor

@iamfil iamfil commented Feb 28, 2025

Remove extra forward slash that prevents tv logos from loading.

Description

When not running in Dev mode, an extra / is added to the URLs for locally stored tv logos. This prevents them from loading.

Issues (Fixed or Closed)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Testing Instructions

  • Steps to reproduce/test the changes
  1. Run StreamMaster WebUI but not in Dev mode. (npm run builddev)
  2. Try to list logos for a channel
  3. Without this change, they fail to load. With this change, they load!

Visual Changes

  • Screenshots/videos attached

Before
image

After
image

Checklist

  • I have followed the Conventional Commits naming convention
  • My branch is up to date with the main branch (rebased)
  • My code follows the style guidelines and existing patterns of this project
  • I have performed a self-review of my own code
  • I have commented complex logic
  • I have added tests (if applicable)
  • All tests are passing
  • I have updated documentation as needed

carlreid
carlreid approved these changes Mar 1, 2025
View reviewed changes
Copy link
Owner

@carlreid carlreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks again @iamfil 🙏

@carlreid carlreid merged commit bab42ea into carlreid:main Mar 1, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlreid carlreid carlreid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamfil @carlreid