Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "generate-stackbrew-library.sh" to generate appropriate Architectures values (and use the new RFC 2822-based format) #49

Merged
merged 1 commit into from
Sep 13, 2017

Conversation

tianon
Copy link
Contributor

@tianon tianon commented Sep 13, 2017

I tried to match your branch logic, but not sure I got it 100% correct (and not 100% sure how you're using those bits either 😇).

I'm happy to make the official-images PR for this once it's merged too, if you'd like! 👍

Closes #45

…ectures values (and use the new RFC 2822-based format)
@tianon
Copy link
Contributor Author

tianon commented Sep 13, 2017

Here's what the output of this looks like:

$ ./generate-stackbrew-library.sh
Maintainers: Carlos Sanchez <carlos@apache.org> (@carlossg)
GitRepo: https://github.com/carlossg/docker-maven.git

Tags: 3.5.0-jdk-7, 3.5-jdk-7, 3-jdk-7
Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, ppc64le, s390x
GitCommit: 4b6cf057428dec330e39af811b54a6abd000402a
Directory: jdk-7

Tags: 3.5.0-jdk-7-alpine, 3.5-jdk-7-alpine, 3-jdk-7-alpine
Architectures: amd64
GitCommit: bdcedecba28295e7fc91256c9e58b0cc1f69ed57
Directory: jdk-7-alpine

Tags: 3.5.0-jdk-7-slim, 3.5-jdk-7-slim, 3-jdk-7-slim
Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, ppc64le, s390x
GitCommit: afebe58fedee70782887d8bce0fdf808851593fd
Directory: jdk-7-slim

Tags: 3.5.0-jdk-8, 3.5.0, 3.5-jdk-8, 3.5, 3-jdk-8, 3, latest
Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, ppc64le, s390x
GitCommit: 7fe1595b23769f777515ae3beca30003349a5ebb
Directory: jdk-8

Tags: 3.5.0-jdk-8-alpine, 3.5.0-alpine, 3.5-jdk-8-alpine, 3.5-alpine, 3-jdk-8-alpine, alpine
Architectures: amd64
GitCommit: bdcedecba28295e7fc91256c9e58b0cc1f69ed57
Directory: jdk-8-alpine

Tags: 3.5.0-jdk-8-slim, 3.5.0-slim, 3.5-jdk-8-slim, 3.5-slim, 3-jdk-8-slim, slim
Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, ppc64le, s390x
GitCommit: afebe58fedee70782887d8bce0fdf808851593fd
Directory: jdk-8-slim

Tags: 3.5.0-jdk-9, 3.5-jdk-9, 3-jdk-9
Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, ppc64le, s390x
GitCommit: 4b6cf057428dec330e39af811b54a6abd000402a
Directory: jdk-9

Tags: 3.5.0-jdk-9-slim, 3.5-jdk-9-slim, 3-jdk-9-slim
Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, ppc64le, s390x
GitCommit: afebe58fedee70782887d8bce0fdf808851593fd
Directory: jdk-9-slim

Tags: 3.5.0-ibmjava-8, 3.5.0-ibmjava, 3.5-ibmjava-8, 3.5-ibmjava, 3-ibmjava-8, 3-ibmjava, ibmjava
Architectures: amd64, i386, ppc64le, s390x
GitCommit: 4b6cf057428dec330e39af811b54a6abd000402a
Directory: ibmjava-8

Tags: 3.5.0-ibmjava-8-alpine, 3.5.0-ibmjava-alpine, 3.5-ibmjava-8-alpine, 3.5-ibmjava-alpine, 3-ibmjava-8-alpine, ibmjava-alpine
Architectures: amd64
GitCommit: bdcedecba28295e7fc91256c9e58b0cc1f69ed57
Directory: ibmjava-8-alpine

Tags: 3.5.0-ibmjava-9, 3.5-ibmjava-9, 3-ibmjava-9
Architectures: amd64, i386, ppc64le, s390x
GitCommit: 4b6cf057428dec330e39af811b54a6abd000402a
Directory: ibmjava-9

Tags: 3.5.0-ibmjava-9-alpine, 3.5-ibmjava-9-alpine, 3-ibmjava-9-alpine
Architectures: amd64
GitCommit: bdcedecba28295e7fc91256c9e58b0cc1f69ed57
Directory: ibmjava-9-alpine

@tianon
Copy link
Contributor Author

tianon commented Sep 13, 2017

And the output of diff -u <(bashbrew list maven | cut -d: -f2 | sort) <(bashbrew list <(./gene rate-stackbrew-library.sh) | cut -d: -f2 | sort) is empty, which is a good sign (means we didn't lose any tags in the conversion 👍)

@carlossg
Copy link
Owner

the branch argument is no longer used now that everything is in master

@carlossg carlossg merged commit 13e5ea8 into carlossg:master Sep 13, 2017
@tianon tianon deleted the multiarch branch September 13, 2017 18:41
@tianon
Copy link
Contributor Author

tianon commented Sep 13, 2017

Ah, that makes sense! 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants