Skip to content

start restriction for more fine-grained control policies #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2020
Merged

start restriction for more fine-grained control policies #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,3 +127,6 @@ override.tf.json
# End of https://www.gitignore.io/api/osx,ruby,terraform,visualstudiocode

.kitchen/

## IDEA based IDEs
.idea
248 changes: 170 additions & 78 deletions modules/iam/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,36 @@ data "aws_iam_policy_document" "segment_data_lake_policy_document" {
effect = "Allow"
}

# Explicitly deny Segment to modify IAM or sensible configuration from the Data Lake S3 bucket.
statement {
sid = "Deny privileged operations"
actions = [
"s3:BypassGovernanceRetention",
"s3:CreateAccessPoint",
"s3:DeleteAccessPoint",
"s3:DeleteAccessPointPolicy",
"s3:DeleteBucket",
"s3:DeleteBucketPolicy",
"s3:PutAccessPointPolicy",
"s3:PutAccountPublicAccessBlock",
"s3:PutBucketAcl",
"s3:PutBucketLogging",
"s3:PutBucketPolicy",
"s3:PutBucketPublicAccessBlock",
"s3:PutBucketVersioning",
"s3:PutBucketWebsite",
"s3:PutEncryptionConfiguration",
"s3:PutReplicationConfiguration"
]

resources = [
"arn:aws:s3:::${var.s3_bucket}/*",
"arn:aws:s3:::${var.s3_bucket}",
]

effect = "Deny"
}

# Allows Segment to access Athena.
statement {
actions = [
Expand Down Expand Up @@ -182,84 +212,146 @@ EOF
tags = "${local.tags}"
}

resource "aws_iam_role_policy" "segment_emr_service_policy" {
name = "SegmentEMRServicePolicy${var.suffix}"
role = "${aws_iam_role.segment_emr_service_role.id}"
resource "aws_iam_policy" "segment_emr_service_role_policy" {
name = "SegmentEMRServicePolicy${var.suffix}"
path = "/"
policy = "${data.aws_iam_policy_document.segment_emr_service_policy_document.json}"
tags = "${local.tags}"
}

policy = <<EOF
{
"Version": "2012-10-17",
"Statement": [{
"Effect": "Allow",
"Resource": "*",
"Action": [
"ec2:AuthorizeSecurityGroupEgress",
"ec2:AuthorizeSecurityGroupIngress",
"ec2:CancelSpotInstanceRequests",
"ec2:CreateNetworkInterface",
"ec2:CreateSecurityGroup",
"ec2:CreateTags",
"ec2:DeleteNetworkInterface",
"ec2:DeleteSecurityGroup",
"ec2:DeleteTags",
"ec2:DescribeAvailabilityZones",
"ec2:DescribeAccountAttributes",
"ec2:DescribeDhcpOptions",
"ec2:DescribeImages",
"ec2:DescribeInstanceStatus",
"ec2:DescribeInstances",
"ec2:DescribeKeyPairs",
"ec2:DescribeNetworkAcls",
"ec2:DescribeNetworkInterfaces",
"ec2:DescribePrefixLists",
"ec2:DescribeRouteTables",
"ec2:DescribeSecurityGroups",
"ec2:DescribeSpotInstanceRequests",
"ec2:DescribeSpotPriceHistory",
"ec2:DescribeSubnets",
"ec2:DescribeTags",
"ec2:DescribeVpcAttribute",
"ec2:DescribeVpcEndpoints",
"ec2:DescribeVpcEndpointServices",
"ec2:DescribeVpcs",
"ec2:DetachNetworkInterface",
"ec2:ModifyImageAttribute",
"ec2:ModifyInstanceAttribute",
"ec2:RequestSpotInstances",
"ec2:RevokeSecurityGroupEgress",
"ec2:RunInstances",
"ec2:TerminateInstances",
"ec2:DeleteVolume",
"ec2:DescribeVolumeStatus",
"ec2:DescribeVolumes",
"ec2:DetachVolume",
"iam:GetRole",
"iam:GetRolePolicy",
"iam:ListInstanceProfiles",
"iam:ListRolePolicies",
"iam:PassRole",
"s3:CreateBucket",
"s3:Get*",
"s3:List*",
"sdb:BatchPutAttributes",
"sdb:Select",
"sqs:CreateQueue",
"sqs:Delete*",
"sqs:GetQueue*",
"sqs:PurgeQueue",
"sqs:ReceiveMessage",
"cloudwatch:PutMetricAlarm",
"cloudwatch:DescribeAlarms",
"cloudwatch:DeleteAlarms",
"application-autoscaling:RegisterScalableTarget",
"application-autoscaling:DeregisterScalableTarget",
"application-autoscaling:PutScalingPolicy",
"application-autoscaling:DeleteScalingPolicy",
"application-autoscaling:Describe*"
]
}]
data "aws_iam_policy_document" "segment_emr_service_policy_document" {
statement {
sid = "AllowSegmentEMRServicePolicy${var.suffix}"
effect = "Allow"
actions = [
"ec2:AuthorizeSecurityGroupEgress",
"ec2:AuthorizeSecurityGroupIngress",
"ec2:CancelSpotInstanceRequests",
"ec2:CreateNetworkInterface",
"ec2:CreateSecurityGroup",
"ec2:CreateTags",
"ec2:DeleteNetworkInterface",
"ec2:DeleteSecurityGroup",
"ec2:DeleteTags",
"ec2:DescribeAvailabilityZones",
"ec2:DescribeAccountAttributes",
"ec2:DescribeDhcpOptions",
"ec2:DescribeImages",
"ec2:DescribeInstanceStatus",
"ec2:DescribeInstances",
"ec2:DescribeKeyPairs",
"ec2:DescribeNetworkAcls",
"ec2:DescribeNetworkInterfaces",
"ec2:DescribePrefixLists",
"ec2:DescribeRouteTables",
"ec2:DescribeSecurityGroups",
"ec2:DescribeSpotInstanceRequests",
"ec2:DescribeSpotPriceHistory",
"ec2:DescribeSubnets",
"ec2:DescribeTags",
"ec2:DescribeVpcAttribute",
"ec2:DescribeVpcEndpoints",
"ec2:DescribeVpcEndpointServices",
"ec2:DescribeVpcs",
"ec2:DetachNetworkInterface",
"ec2:ModifyImageAttribute",
"ec2:ModifyInstanceAttribute",
"ec2:RequestSpotInstances",
"ec2:RevokeSecurityGroupEgress",
"ec2:RunInstances",
// "ec2:TerminateInstances",
// "ec2:DeleteVolume",
"ec2:DescribeVolumeStatus",
"ec2:DescribeVolumes",
// "ec2:DetachVolume",
"iam:GetRole",
"iam:GetRolePolicy",
"iam:ListInstanceProfiles",
"iam:ListRolePolicies",
"iam:PassRole",
"s3:CreateBucket",
// "s3:Get*",
// "s3:List*",
"sdb:BatchPutAttributes",
"sdb:Select",
// "sqs:CreateQueue",
// "sqs:Delete*",
// "sqs:GetQueue*",
// "sqs:PurgeQueue",
// "sqs:ReceiveMessage",
"cloudwatch:PutMetricAlarm",
"cloudwatch:DescribeAlarms",
"cloudwatch:DeleteAlarms",
"application-autoscaling:RegisterScalableTarget",
"application-autoscaling:DeregisterScalableTarget",
"application-autoscaling:PutScalingPolicy",
"application-autoscaling:DeleteScalingPolicy",
"application-autoscaling:Describe*"
]
resources = [
"*",
]
}

statement {
actions = [
"ec2:DeleteVolume",
"ec2:TerminateInstances",
"ec2:DetachVolume",
]
resources = [
"*"
]
# Check that were created by Segment
// condition {
// test = ""
// values = []
// variable = ""
// }
effect = "Allow"
}

statement {
actions = [
"sqs:CreateQueue",
"sqs:Delete*",
"sqs:GetQueue*",
"sqs:PurgeQueue",
"sqs:ReceiveMessage",
]
resources = [
"*"
]
# Check that were created by Segment
// condition {
// test = ""
// values = []
// variable = ""
// }
effect = "Allow"
}

statement {
actions = [
"s3:Get*",
"s3:List*"
]
resources = [
"*"
]
# Check that S3 was created by Segment
// condition {
// test = ""
// values = []
// variable = ""
// }
effect = "Allow"
}
}
EOF

resource "aws_iam_role_policy_attachment" "segment_emr_service_role_policy_attachment" {
role = "${aws_iam_role.segment_emr_service_role.name}"
policy_arn = "${aws_iam_policy.segment_emr_service_role_policy.arn}"
}

# IAM Role for EC2 Instance Profile
Expand All @@ -286,8 +378,8 @@ EOF
}

resource "aws_iam_instance_profile" "segment_emr_instance_profile" {
name = "SegmentEMRInstanceProfile${var.suffix}"
roles = ["${aws_iam_role.segment_emr_instance_profile_role.name}"]
name = "SegmentEMRInstanceProfile${var.suffix}"
role = "${aws_iam_role.segment_emr_instance_profile_role.name}"
}

resource "aws_iam_role_policy" "segment_emr_instance_profile_policy" {
Expand Down