Skip to content

Commit

Permalink
Exemplars SHOULD be on by default (open-telemetry#3994)
Browse files Browse the repository at this point in the history
  • Loading branch information
reyang authored Apr 16, 2024
1 parent cb25db8 commit 4357586
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ release.
([#3872](https://github.com/open-telemetry/opentelemetry-specification/pull/3872))
- Add synchronous gauge entry to sum monotonic table.
([#3977](https://github.com/open-telemetry/opentelemetry-specification/pull/3977))
- Change the exemplar behavior to be on by default.
([#3994](https://github.com/open-telemetry/opentelemetry-specification/pull/3994))

### Logs

Expand Down
2 changes: 1 addition & 1 deletion specification/metrics/sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -1005,7 +1005,7 @@ While the metric data point for the counter would carry the attributes `X` and
A Metric SDK MUST provide a mechanism to sample `Exemplar`s from measurements
via the `ExemplarFilter` and `ExemplarReservoir` hooks.

`Exemplar` sampling SHOULD be turned off by default. If `Exemplar` sampling is
`Exemplar` sampling SHOULD be turned on by default. If `Exemplar` sampling is
off, the SDK MUST NOT have overhead related to exemplar sampling.

A Metric SDK MUST allow exemplar sampling to leverage the configuration of
Expand Down

0 comments on commit 4357586

Please sign in to comment.