Skip to content

Commit

Permalink
Merge pull request duckdb#12924 from ZhangHuiGui/simplify-and-remove-…
Browse files Browse the repository at this point in the history
…useless-codes

Minor refactor for window_executor
  • Loading branch information
Mytherin authored Jul 10, 2024
2 parents 32e1a0b + 115b84d commit 104cb79
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/execution/window_executor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ static idx_t FindOrderedRangeBound(const WindowInputColumn &over, const OrderTyp

struct WindowBoundariesState {
static inline bool IsScalar(const unique_ptr<Expression> &expr) {
return expr ? expr->IsScalar() : true;
return !expr || expr->IsScalar();
}

static inline bool BoundaryNeedsPeer(const WindowBoundary &boundary) {
Expand Down Expand Up @@ -1121,8 +1121,6 @@ class WindowAggregateExecutorLocalState : public WindowExecutorBoundsState {
public:
// state of aggregator
unique_ptr<WindowAggregatorState> aggregator_state;

void NextRank(idx_t partition_begin, idx_t peer_begin, idx_t row_idx);
};

unique_ptr<WindowExecutorLocalState>
Expand Down

0 comments on commit 104cb79

Please sign in to comment.