Skip to content

Conversation

kornholi
Copy link
Contributor

@kornholi kornholi commented Dec 3, 2019

No description provided.

@kornholi
Copy link
Contributor Author

kornholi commented Dec 5, 2019

@lnicola does this look good? I think I'll have to rebase the other PR after this gets merged

@lnicola
Copy link
Collaborator

lnicola commented Dec 5, 2019

It does, but I'm not really familiar with the code and I didn't feel comfortable merging it. But as they say, "it's better to ask forgiveness it is to get permission".

So thank you for this work!

@lnicola lnicola merged commit 563ce53 into carllerche:master Dec 5, 2019
@kornholi kornholi deleted the feat/update-macros branch December 5, 2019 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants