update JRS document #173
Merged
update JRS document #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulienStitelet
approved these changes
Mar 8, 2022
MalarCB
reviewed
Mar 8, 2022
| | Param | Type | Required | Description | | ||
| |----------|------|----------|-------------| | ||
| | `email_address` | String | **TRUE** | The email of the registered user. | ||
| | `jobID` | String | **True** | This needs to be a valid jobdid. |
There was a problem hiding this comment.
i have a question not related to this PR. Any reason to add input as camelcase? i see many of our apps where the inputs are snakecase.
There was a problem hiding this comment.
Before the job recommendation workflow is frontend -> visitor-recs-js -> JRS. After migration the workflow become frontend -> JRS. Since this frontend use camelcase and we try to avoid asking frontend team to update frontend, we have to use camelcase.
MalarCB
approved these changes
Mar 8, 2022
ashraj10c1
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.