Filter out empty messages from LLM prompt construction #3967
+284
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty messages (with no content and no tool calls) could be sent to the LLM, which is wasteful and potentially causes issues. This change: - Skips assistant messages with empty body and no tool calls during history construction (matching the existing guard on user messages) - Adds a safety filter (hasMessageContent) on the final messages array to catch any empty messages from any source, while preserving assistant messages with tool calls and tool response messages CS-10116 https://claude.ai/code/session_01JMzG85yR6uQUXVfnUTegXz
- Remove hasMessageContent filter: it was redundant with the inline guards already present for each message type and would silently mask construction bugs rather than surfacing them - Fix test: use correct field name `id` instead of `toolCallId` for encoded command requests (matching all other tests in the file) - Add tool result assertions to verify the assistant+tool message pairing is preserved when assistant body is empty https://claude.ai/code/session_01JMzG85yR6uQUXVfnUTegXz
Contributor
Author
|
@claude iterate to fix the linting and test issues. One of the matrix tests is failing because there is an expect for one attached file that should be checking the count is 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty messages (with no content and no tool calls) could be sent to the
LLM, which is wasteful and potentially causes issues. This change:
history construction (matching the existing guard on user messages)
to catch any empty messages from any source, while preserving
assistant messages with tool calls and tool response messages
CS-10116
https://claude.ai/code/session_01JMzG85yR6uQUXVfnUTegXz