Skip to content

Conversation

@ldm0
Copy link
Collaborator

@ldm0 ldm0 commented Jan 1, 2026

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes the behavior when filesystem rescan errors occur - instead of automatically triggering a full rescan, the system now tracks and displays a count of rescan errors to the user. The error count is shown in the rescan button's tooltip, providing visibility into filesystem issues without the disruption of automatic rescans.

Key Changes:

  • Removed automatic rescan behavior when HandleFSEError::Rescan is encountered
  • Added rescanErrors counter tracked throughout the application stack
  • Enhanced rescan button tooltip to display the count of filesystem errors when present

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
cardinal/src/types/ipc.ts Added rescanErrors field to status bar update payload type
cardinal/src/hooks/useFileSearch.ts Added rescanErrors to search state and updated handler signatures
cardinal/src/components/StatusBar.tsx Added rescanErrorCount prop and enhanced tooltip to display error count
cardinal/src/App.tsx Threaded rescanErrors state from IPC events to StatusBar component
cardinal/src/App.css Minor whitespace formatting changes
cardinal/src-tauri/src/lib.rs Updated emit_status_bar_update calls to include rescan error count (0)
cardinal/src-tauri/src/background.rs Replaced automatic rescan on errors with error counter increment; added throttling to status updates
cardinal/src/i18n/resources/*.json Added errorCountSuffix translation key across all 15 supported languages

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ldm0 ldm0 merged commit 2d25030 into master Jan 1, 2026
9 checks passed
@ldm0 ldm0 deleted the rescan_not_frequent branch January 1, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants