Rename 'whitelist' to 'ignore_list' #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and allow it to be used to solve the Scunthorpe problem: https://en.wikipedia.org/wiki/Scunthorpe_problem
Technically a Regexp object would have been interpolated anyway, but I thought it would be more efficient this way, and better to explicitly support it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and allow it to be used to solve the Scunthorpe problem.
There are a couple of things going on here: firstly I had a couple of cases of the scunthorpe problem which weren't addressed using the original whitelist solution. Secondly, I and others have been trying to avoid problematic language in my code, and "whitelist" falls into that category. I appreciate that this is a breaking change, and if you like I can add another commit to make it backwards-compatible.