Skip to content

Commit

Permalink
Merge branch 'main' into bugfix/ocp-414-link
Browse files Browse the repository at this point in the history
  • Loading branch information
cardil authored Aug 29, 2023
2 parents de87c0f + e85c447 commit e3a085e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 13 deletions.
10 changes: 2 additions & 8 deletions test/serving.bash
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,6 @@ function upstream_knative_serving_e2e_and_conformance_tests {
sed -ie '47,51d' ./test/conformance/runtime/protocol_test.go
fi

ocp_version=$(oc get clusterversion version -o jsonpath='{.status.desired.version}')

# Disable cgroups test on OCP 4.14+ until it supports cgroups v2.
# https://issues.redhat.com/browse/SRVKS-1111
if versions.ge "$(versions.major_minor "$ocp_version")" 4.14; then
rm ./test/conformance/runtime/cgroup_test.go
fi

local parallel=16

if [[ $(oc get infrastructure cluster -ojsonpath='{.status.platform}') = VSphere ]]; then
Expand Down Expand Up @@ -156,6 +148,8 @@ function upstream_knative_serving_e2e_and_conformance_tests {
oc -n "$SERVING_NAMESPACE" patch hpa activator --patch \
'{"spec": {"maxReplicas": '"${max_replicas}"', "minReplicas": '"${min_replicas}"'}}'

ocp_version=$(oc get clusterversion version -o jsonpath='{.status.desired.version}')

# Feature is tested on 4.11+ as this is the version we start enabling it by default.
if versions.ge "$(versions.major_minor "$ocp_version")" "4.11"; then
# Enable secure pod defaults for the following tests.
Expand Down
10 changes: 5 additions & 5 deletions test/servinge2e/kourier/service_to_service_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,6 @@ import (
// services from within the cluster.
func TestServiceToServiceCalls(t *testing.T) {

caCtx := test.SetupClusterAdmin(t)
test.CleanupOnInterrupt(t, func() { test.CleanupAll(t, caCtx) })
defer test.CleanupAll(t, caCtx)

tests := []testCase{{
// Requests go via gateway -> activator -> pod.
name: "service-call-via-activator",
Expand Down Expand Up @@ -58,7 +54,11 @@ func TestServiceToServiceCalls(t *testing.T) {
for _, scenario := range tests {
scenario := scenario
t.Run(scenario.name, func(t *testing.T) {
testServiceToService(t, caCtx, test.Namespace, scenario)
// Create a new context to prevent calling ctx.T.Fatal on parent T.
ctx := test.SetupClusterAdmin(t)
test.CleanupOnInterrupt(t, func() { test.CleanupAll(t, ctx) })
defer test.CleanupAll(t, ctx)
testServiceToService(t, ctx, test.Namespace, scenario)
})
}
}
Expand Down

0 comments on commit e3a085e

Please sign in to comment.