Bump haskell.nix #738
Bump haskell.nix #738
Conversation
|
Thanks @andreabedini. If this is building, this should be good to go? i.e. "ready for review". Also note, that we usually do rebase our changes on top of master (instead of merging master into our branches). |
andreabedini
force-pushed
the
bump-haskell-nix
branch
from
7eb3729 to
cbe2078
Compare
Yes!
Ok, just rebased. Feel free to merge when it's green again :) |
| "owner": "input-output-hk", | ||
| "repo": "haskell.nix", | ||
| "rev": "6a971848cb717d8d0c8db71bd1c1d9fd38f02851", | ||
| "rev": "4883bba92116b54db92182ca24841c0aa922c9d6", |
There was a problem hiding this comment.
@andreabedini Is this seriously the diff of haskell.nix between these two commits? https://github.com/input-output-hk/haskell.nix/compare/6a971848cb717d8d0c8db71bd1c1d9fd38f02851..4883bba92116b54db92182ca24841c0aa922c9d6 :o
There was a problem hiding this comment.
Yes it is. It's ~100 of business logic change but it's right at the core of it. This makes a change in the way the cabal plan is represent in nix and, as a consequence, all materialisations have to be redone and all the compiliers and tools end up being rebuilt.
Haskell.nix had broken support for cabal file revisions in a repository other than hackage. E.g. a cabal file revision in Hackage would be picked up and work properly; while a cabal file revision in CHaP will cause haskell.nix to error out. Haskell.nix fixed that only two weeks ago. A cabal file revision appeared on CHaP today. Any project which uses a version of haskell.nix older than two week will have issues bumping CHaP, unless haskell.nix gets bumped too. I have been preventively bumping haskell.nix everywhere to find issues and warm up the caches (as you can tell it's a big change). |
andreabedini
force-pushed
the
bump-haskell-nix
branch
from
cbe2078 to
822153a
Compare
The bump is to support cabal file revisions on CHaP which are necessary to get our packages to build without all those manual constraints we have in cabal.project.
I am opening a draft PR to test the waters and warm up the chaces ahead of time since it's relatively big change in haskell.nix. I'll make sure everything works and then mark it as ready.