Add -Wmissing-import-lists and -Wmissing-local-signatures to werrorwolf check #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locallycompact
force-pushed
the
lc/werrorwolf-extra-flags
branch
from
e7e9003 to
e172554
Compare
locallycompact
force-pushed
the
lc/werrorwolf-extra-flags
branch
from
e172554 to
8c00f63
Compare
|
... why? 😅 |
|
So we always know where symbols come from and what that thing there is. |
|
While I personally like the feature; I don't want to force it on every potential repo; especially if they have specifically opted against it. |
|
Yes, well, of course it's always possible to explicitly opt out of anything in this module which is stated in the README. I think these options should certainly be opt-out rather than opt-in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will forcibly add the flags
-Wmissing-import-listsand-Wmissing-local-signaturesto all-Werrorchecks derived from haskell projects regardless of the project settings.