-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to build with cabal #2027
Merged
iohk-bors
merged 8 commits into
cardano-foundation:master
from
hasufell:PR/fix-cabal-build
Sep 30, 2020
Merged
Allow to build with cabal #2027
iohk-bors
merged 8 commits into
cardano-foundation:master
from
hasufell:PR/fix-cabal-build
Sep 30, 2020
Commits on Sep 25, 2020
-
The process to create these files is as follows: 1. Run stack2cabal 2. Disable tests and benchmarks of local packages (those specified via source-repository-package... this won't be needed with cabal-3.4 anymore, because it won't treat them as local anymore) 3. Hackage packages in `packages` in `cardano-1.19.x.yaml` or `extra-deps` in `stack.yaml`, which are specified as git repositories might have different versions than the stack resolver. `stack2cabal` cannot pick these up, so these must be adjusted manually (or deleted) in `cabal.project.freeze` (at the time of writing: http-client and persistent). Rationale: 1. good to support all available tools as options for interested users 2. cabal allows easier managing of package bounds (and testing against latest package versions and different GHCs, because it is not constrained to stackage) 3. doesn't require nix, which is an additional step to set up and maintain and requires significant amount of disk space
Julian Ospald committedSep 25, 2020 Configuration menu - View commit details
-
Copy full SHA for 0b2888b - Browse repository at this point
Copy the full SHA 0b2888bView commit details -
Fix build for cabal users that don't have systemd
This is mainly due to a cabal bug and should be removed in the future: haskell/cabal#5444 There are various distros, where installing development files of libsystemd won't be an option: - Alpine (doesn't have systemd at all) - Gentoo (not installable when eudev is installed) - Exherbo (not installable when eudev is installed) Users are expected to run the script and then execute cabal like so: cabal build --project-file=cabal.nosystemd.project all
Julian Ospald committedSep 25, 2020 Configuration menu - View commit details
-
Copy full SHA for 5918d83 - Browse repository at this point
Copy the full SHA 5918d83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88df4b6 - Browse repository at this point
Copy the full SHA 88df4b6View commit details
Commits on Sep 28, 2020
-
Pin GHC to 8.6.5 to avoid confusion
Julian Ospald committedSep 28, 2020 Configuration menu - View commit details
-
Copy full SHA for cee5263 - Browse repository at this point
Copy the full SHA cee5263View commit details -
Configuration menu - View commit details
-
Copy full SHA for 540ef34 - Browse repository at this point
Copy the full SHA 540ef34View commit details
Commits on Sep 30, 2020
-
nix: Add a shell file which can be used for plain cabal builds
The Haskell.nix shellFor function provides Haskell package dependencies and all their dependencies. This new nix/cabal-shell.nix file only provides a compiler, build tools and system libraries, and lets Cabal build the Haskell package dependencies.
Configuration menu - View commit details
-
Copy full SHA for 98008b8 - Browse repository at this point
Copy the full SHA 98008b8View commit details -
Add an alternate Cabal project file for nix+cabal builds
Using nix-shell and "cabal build --project-file=cabal-nix.project", all Haskell dependencies will be downloaded from the IOHK cache, rather than built locally.
Configuration menu - View commit details
-
Copy full SHA for b8dd195 - Browse repository at this point
Copy the full SHA b8dd195View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17c3de1 - Browse repository at this point
Copy the full SHA 17c3de1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.