Canonicalize imported witness blocks on FacetValue #6458
Merged
+296
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmeow
force-pushed
the
witnesses
branch
2 times, most recently
from
48e069c to
5a9efbb
Compare
chandlerc
approved these changes
Dec 3, 2025
Contributor
chandlerc
left a comment
chandlerc
left a comment
There was a problem hiding this comment.
LG, and really nice test to isolate this!
Comment inline is just confirming my understanding, no change needed.
| CARBON_FATAL("Unhandled inst: {0}", inst); | ||
| } | ||
| } | ||
| llvm::sort(sortable, [](auto& lhs, auto& rhs) { |
Contributor
There was a problem hiding this comment.
I expect that this is true, but figured I would check -- there can't be cases with the same specific interface IDs, and so this is a total order and not a partial order?
Contributor
Author
There was a problem hiding this comment.
Identical specifics should be deduplicated (as an example, see above SortAndDeduplicate(required_interfaces_, RequiredLess);). That should happen during construction, and at this point we shouldn't need to deduplicate.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test has a more complete explanation of this; witnesses on the FacetValue must have a canonical ordering.