Update LLVM version, fix breaks #4886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 3, 2025
Although migration tooling is intended for Carbon, this tooling was primarily a proof-of-concept prototype. The last time it got significant work was in 2022 (https://github.com/carbon-language/carbon-lang/commits/trunk/migrate_cpp); since then, we've mainly been doing small cleanups to keep it building. We're now hitting an issue in #4886 that `TypeNodes.inc` isn't exposed as a `#include`. We already had thoughts about rewriting this as a `RecursiveASTVisitor`, per `rewriter.cpp`/`rewriter.h`. That may justify a significantly different approach than had been set up in `cpp_refactoring`. But, it's hard to tell. Either way, my sense is that rather than incrementally trying to keep this code building, we should revisit it when we're ready and have a long-term strategy for how migration should work.
dwblaikie
approved these changes
Feb 4, 2025
Contributor
dwblaikie
left a comment
dwblaikie
left a comment
There was a problem hiding this comment.
Not rightly sure what to look for when reviewing this - but checked the bits you mentioned in the description, and glanced at the lowering test changes to IR output - looks plausible to me.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
I expect just "does this look reasonable" levels of review. Or "is this maybe making an accidental change that isn't clearly due to the LLVM update". |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proto_libraryuses without aload, which is broken in bazel 8WORKSPACEis a bigger issue LLVM probably should address.migrate_cpp, in Remove legacy migration prototype #4887