-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raw identifier syntax #3797
Merged
zygoloid
merged 9 commits into
carbon-language:trunk
from
jonmeow:proposal-raw-identifier-synta
May 1, 2024
Merged
Raw identifier syntax #3797
zygoloid
merged 9 commits into
carbon-language:trunk
from
jonmeow:proposal-raw-identifier-synta
May 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmeow
force-pushed
the
proposal-raw-identifier-synta
branch
from
March 19, 2024 22:17
e74b2fa
to
e3c02cc
Compare
jonmeow
force-pushed
the
proposal-raw-identifier-synta
branch
2 times, most recently
from
March 19, 2024 23:22
5d75586
to
1c86143
Compare
jonmeow
force-pushed
the
proposal-raw-identifier-synta
branch
from
March 20, 2024 23:44
9daa9c4
to
89e829c
Compare
jonmeow
force-pushed
the
proposal-raw-identifier-synta
branch
from
March 28, 2024 18:27
89e829c
to
b290484
Compare
jonmeow
force-pushed
the
proposal-raw-identifier-synta
branch
5 times, most recently
from
April 1, 2024 19:58
581b482
to
998f131
Compare
github-actions
bot
added
the
proposal rfc
Proposal with request-for-comment sent out
label
Apr 1, 2024
Co-authored-by: Carbon Infra Bot <carbon-external-infra@google.com>
zygoloid
reviewed
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
jonmeow
force-pushed
the
proposal-raw-identifier-synta
branch
from
April 3, 2024 22:40
1467bdf
to
d7c481b
Compare
jonmeow
force-pushed
the
proposal-raw-identifier-synta
branch
from
April 12, 2024 05:12
65af1ca
to
db8602d
Compare
jonmeow
force-pushed
the
proposal-raw-identifier-synta
branch
from
April 29, 2024 15:22
db8602d
to
06ab1c2
Compare
zygoloid
approved these changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No concerns identified, and this matches the toolchain. Approved on behalf of leads.
chandlerc
pushed a commit
to chandlerc/carbon-lang
that referenced
this pull request
May 2, 2024
We want to support legacy identifiers that overlap with new keywords (for example, `base`). This is being called "raw identifier syntax" using `r#<identifier>`, and is based on [Rust](https://doc.rust-lang.org/reference/identifiers.html). Note this proposal is derived from [Proposal carbon-language#17: Lexical conventions](carbon-language#17). Co-authored-by: zygoloid <richard@metafoo.co.uk> --------- Co-authored-by: Carbon Infra Bot <carbon-external-infra@google.com>
CJ-Johnson
pushed a commit
to CJ-Johnson/carbon-lang
that referenced
this pull request
May 23, 2024
We want to support legacy identifiers that overlap with new keywords (for example, `base`). This is being called "raw identifier syntax" using `r#<identifier>`, and is based on [Rust](https://doc.rust-lang.org/reference/identifiers.html). Note this proposal is derived from [Proposal carbon-language#17: Lexical conventions](carbon-language#17). Co-authored-by: zygoloid <richard@metafoo.co.uk> --------- Co-authored-by: Carbon Infra Bot <carbon-external-infra@google.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
Feature approved in #3797 --------- Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to support legacy identifiers that overlap with new keywords (for example,
base
). This is being called "raw identifier syntax" usingr#<identifier>
, and is based on Rust.Note this proposal is derived from Proposal #17: Lexical conventions.
Co-authored-by: zygoloid richard@metafoo.co.uk