Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next #1138

Merged
merged 30 commits into from
Jul 19, 2021
Merged

Next #1138

merged 30 commits into from
Jul 19, 2021

Conversation

vpicone
Copy link
Contributor

@vpicone vpicone commented Jun 23, 2021 •
edited
Loading

closes #1135

Breaking Changes

  • update minimum Gatsby and Gatsby plugins version to v3
  • fix v3 related errors
  • remove emotion wrapper and dependencies

Added

vpicone and others added 26 commits April 14, 2021 16:52
@vpicone
chore: update gatsby and react
dbaef44
@vpicone
fix: sassOptions
e7ac68e
@vpicone
chore: update gatsby plugins and remove emotion
9814560
@vpicone
fix: sass module import
a0c3bcc
@vpicone
chore: remove emotion
ccacf91
@vpicone
chore: move homepage to its own component
89ddf98
@vpicone
chore: add pre-release script
355ea94
@vpicone
Merge branch 'main' of https://github.com/carbon-design-system/gatsby…
3670879 
…-theme-carbon into next
@vpicone
chore: remove console logs
1bce648
@vpicone
breaking: migrate to gatsby v3 (#1118)
590e48d 
* chore: update gatsby and react

* fix: sassOptions

* chore: update gatsby plugins and remove emotion

* fix: sass module import

* chore: remove emotion

* chore: move homepage to its own component

* chore: add pre-release script

* chore: remove console logs
@vpicone
Merge branch 'next' of https://github.com/carbon-design-system/gatsby…
c9fcf1a 
…-theme-carbon into next
@vpicone
chore: use major pre-release
9e4622c
@vpicone
chore: npm tag
53ff04c
@vpicone
chore: release 2.0.0-next.0
08b0887
@vpicone
chore: update deps
6fb4ec9
@vpicone
chore: don't force major script
8dc49a4
@vpicone
chore: release 2.0.0-next.1
596a82d
@vpicone
Merge branch 'main' of https://github.com/carbon-design-system/gatsby…
9b7141c 
…-theme-carbon into next
@vpicone
chore: release 2.0.0-next.2
18236d3
@vpicone
chore: more dep updates
df64189
@vpicone
chore: release 2.0.0-next.3
76664ae
@vpicone
fix: useLayoutEffect issues
be4a6ac
@vpicone
fix: useLayoutEffect warnings (#1136)
d297c4d
@vpicone
Merge branch 'next' of https://github.com/carbon-design-system/gatsby…
d51e2ef 
…-theme-carbon into next
@vpicone
Merge branch 'main' of https://github.com/carbon-design-system/gatsby…
e646e55 
…-theme-carbon into next
@vpicone
chore: release 2.0.0-next.4
e3ad6d7
@vercel
Copy link

vercel bot commented Jun 23, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/gatsby-theme-carbon/9X7GzBN78PRrQ3nFLrQhqL4viiBR
✅ Preview: https://gatsby-theme-carbon-git-next-carbon-design-system.vercel.app

@vpicone vpicone marked this pull request as ready for review July 14, 2021 13:20
@vpicone vpicone requested review from a team, aledavila and sstrubberg and removed request for a team July 14, 2021 13:20
sstrubberg
sstrubberg approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@sstrubberg sstrubberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Docs were super helpful.

One suggestion, but I'm not sure if it needs to be in this PR or a future one, but the Example site when you run npx gatsby new my-carbon-site https://github.com/carbon-design-system/gatsby-starter-carbon-theme was immediately broken until I ran through the migration steps. It might make sense to upgrade the Example site to the latest.

aledavila
aledavila approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@aledavila aledavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great migration is straight forward

@vpicone vpicone merged commit 4c125ca into main Jul 19, 2021
@vpicone vpicone deleted the next branch July 19, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstrubberg sstrubberg sstrubberg approved these changes

@aledavila aledavila aledavila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Gatsby v3
3 participants
@vpicone @aledavila @sstrubberg