Skip to content

Commit

Permalink
fix(blockquote): list text color (#321)
Browse files Browse the repository at this point in the history
  • Loading branch information
tay1orjones authored and vpicone committed Aug 8, 2019
1 parent 88864ac commit b4a4c28
Show file tree
Hide file tree
Showing 2 changed files with 58 additions and 42 deletions.
22 changes: 17 additions & 5 deletions packages/example/src/pages/components/markdown.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ For most pages, we recommend starting with a `PageDescription` followed by `Anch
<AnchorLink>Images</AnchorLink>
<AnchorLink>Code blocks</AnchorLink>
<AnchorLink>Tables</AnchorLink>
<AnchorLink>Blockquotes</AnchorLink>
<AnchorLink>Blockquotes and citations</AnchorLink>
</AnchorLinks>

## MDX Frontmatter
Expand Down Expand Up @@ -205,20 +205,32 @@ raw Markdown line up prettily. You can also use inline Markdown.

## Blockquotes and citations

It is more important than ever that we own our own ethos, make palpable our brand values, and incorporate an instantly identifiable IBMness in everything we do.

> This is a Blockquote.
> This line is part of the same quote.
> <cite>– Alison</cite>
> Blockquotes support basic markdown syntax,
> like **bold** ~~strikethroughs~~ and [links.](#)
> 1. As
> 1. Well
> 1. As
> 1. Lists!
It is more important than ever that we own our own ethos, make palpable our brand values, and incorporate an instantly identifiable IBMness in everything we do.
> <cite>– Alison</cite>
#### Code

```markdown path=components/markdown src=https://github.com/carbon-design-system/gatsby-theme-carbon/tree/master/packages/gatsby-theme-carbon/src/components/markdown
> This is a Blockquote.
> This line is part of the same quote.

> Blockquotes support basic markdown syntax,
> like **bold** ~~strikethroughs~~ and [links.](#)

> 1. As
> 1. Well
> 1. As
> 1. Lists!

> <cite>– Alison</cite>
```
Original file line number Diff line number Diff line change
Expand Up @@ -28,43 +28,6 @@
width: calc(100% - 1rem);
}

//---------------------------------------
// Blockquote
//---------------------------------------
.blockquote {
margin: $spacing-08 0 $spacing-08 $spacing-08;
color: $carbon--blue-60;
font-style: italic;
}

.blockquote .paragraph {
@include carbon--type-style('expressive-heading-03', true);
margin-bottom: 0;
}

.blockquote .paragraph--responsive {
// 6 col
@include carbon--breakpoint('md') {
width: calc(75% - 3rem);
}

// 8 col
@include carbon--breakpoint('lg') {
width: calc(66.667% - 3rem);
}
}

// If quote is inside a user specified row then allow the grid code to set the width
:global(.#{$prefix}--row) .blockquote .paragraph {
width: calc(100% - 3rem);
}

.blockquote cite {
@include carbon--type-style('body-long-01');
display: block;
margin-top: $spacing-02;
}

//---------------------------------------
// Responsive widths
//---------------------------------------
Expand Down Expand Up @@ -119,6 +82,47 @@
}
}

//---------------------------------------
// Blockquote
//---------------------------------------
.blockquote {
margin: $spacing-08 0 $spacing-08 $spacing-08;
color: $carbon--blue-60;
font-style: italic;
}

.blockquote .paragraph {
@include carbon--type-style('expressive-heading-03', true);
margin-bottom: 0;
}

.blockquote .paragraph--responsive {
// 6 col
@include carbon--breakpoint('md') {
width: calc(75% - 3rem);
}

// 8 col
@include carbon--breakpoint('lg') {
width: calc(66.667% - 3rem);
}
}

// If quote is inside a user specified row then allow the grid code to set the width
:global(.#{$prefix}--row) .blockquote .paragraph {
width: calc(100% - 3rem);
}

.blockquote cite {
@include carbon--type-style('body-long-01');
display: block;
margin-top: $spacing-02;
}

.blockquote .list-item {
color: $carbon--blue-60;
}

//---------------------------------------
// Headings
//---------------------------------------
Expand Down

1 comment on commit b4a4c28

@vercel
Copy link

@vercel vercel bot commented on b4a4c28 Aug 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.