fix(react): add forward ref to PasswordInput component #5909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 66ffe88 |
|
Deploy preview for carbon-components-react ready! Built with commit 66ffe88 https://deploy-preview-5909--carbon-components-react.netlify.app |
emyarod
reviewed
Apr 22, 2020
…-PasswordInput-component
|
@emyarod Can you help me here? The test cases are not failing in the local but here they are. |
|
@code-blooded-developer you need to fetch the latest changes from |
|
it looks like I'm not able to push to your branch because of permissions, but the steps I referenced above should fix the broken tests |
…-PasswordInput-component
|
@emyarod thank you for the suggestion. I had a different problem with my OS. |
emyarod
approved these changes
Apr 24, 2020
…-PasswordInput-component
tw15egan
approved these changes
Apr 24, 2020
…-PasswordInput-component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5893
Add forward ref to PasswordInput component.
Changelog
Changed
Testing / Reviewing
To test you can add ref on the Password component in the story. One way is to test focus on inputs.