Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overflow-menu): update top-positioned menu's pseudo-element to prevent box-shadow overlap #4668

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

jendowns
Copy link
Contributor

Closes #4667

Small fix to prevent a slight overlap in the box-shadow from the top-positioned menu. 👍

Changelog

Changed

  • update size & position of menu pseudo-element

@jendowns jendowns requested a review from a team as a code owner November 12, 2019 22:47
@ghost ghost requested review from aledavila and emyarod November 12, 2019 22:47
@jendowns jendowns changed the title fix(overflow-menu): update size of top positioned menu options pseudo-element to prevent box-shadow overlap fix(overflow-menu): update top-positioned menu's pseudo-element to prevent box-shadow overlap Nov 12, 2019
@netlify
Copy link

netlify bot commented Nov 12, 2019

Deploy preview for the-carbon-components ready!

Built with commit 640eaf5

https://deploy-preview-4668--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Nov 12, 2019

Deploy preview for carbon-components-react ready!

Built with commit 640eaf5

https://deploy-preview-4668--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Nov 12, 2019

Deploy preview for carbon-elements ready!

Built with commit 640eaf5

https://deploy-preview-4668--carbon-elements.netlify.com

@asudoh asudoh requested a review from a team November 12, 2019 23:36
@ghost ghost requested review from jillianhowarth and removed request for a team November 12, 2019 23:36
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, pending visual review. the vanilla overflow menu trigger button is broken visually but that is a separate issue and will be addressed in #4672

@asudoh asudoh merged commit efa4d2e into carbon-design-system:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OverflowMenu] top-positioned options menu's box-shadow is visible on trigger
4 participants