Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(copy-button): replace copy button with one for code snippet #4517

Merged
merged 2 commits into from
Nov 4, 2019
Merged

fix(copy-button): replace copy button with one for code snippet #4517

merged 2 commits into from
Nov 4, 2019

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Nov 1, 2019

Fixes #3208.

Changelog

Changed

  • Replaced the markup of copy button with the one for code snippet.

@asudoh asudoh requested review from emyarod, jnm2377 and a team November 1, 2019 09:15
@asudoh asudoh requested a review from a team as a code owner November 1, 2019 09:15
@ghost ghost requested review from jillianhowarth and removed request for a team November 1, 2019 09:15
@netlify
Copy link

netlify bot commented Nov 1, 2019 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit d2b2c8c

https://deploy-preview-4517--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Nov 1, 2019 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit d2b2c8c

https://deploy-preview-4517--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Nov 1, 2019 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit d2b2c8c

https://deploy-preview-4517--carbon-components-react.netlify.com

emyarod
emyarod reviewed Nov 1, 2019
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one thing, should we address the tooltip positioning in this PR or separately?

image

@asudoh
Copy link
Contributor Author

asudoh commented Nov 1, 2019

@emyarod Good point, I think we should address that separately.

emyarod
emyarod approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me pending design review, let's address the tooltip alignment issue separately

aagonzales
aagonzales requested changes Nov 1, 2019
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the icon is off center vertically by 2px. The tooltip is also showing up a little off centered as well.

image

@aagonzales
Copy link
Member

Oh oops I didn't read the other reviews. Would the icon alignment be part of that other issue? (in addition to the tooltip alignment.

@asudoh
Copy link
Contributor Author

asudoh commented Nov 1, 2019

Thank you for reviewing @aagonzales - I think icon alignment will be part of that other issues, too, given I can see the same issue at http://react.carbondesignsystem.com/?path=/story/copybutton--default. This PR focuses on aligning vanilla markup to React given that's all (or at least most) of what #3208 effectively requests for.

@asudoh asudoh merged commit f530510 into carbon-design-system:master Nov 4, 2019
@asudoh asudoh deleted the update-copy-button branch November 4, 2019 21:55
asudoh added a commit to asudoh/carbon-components that referenced this pull request Nov 5, 2019
@asudoh
fix(code-snippet): fix tooltip position
da5d92b 
Refs carbon-design-system#4517.
@asudoh asudoh mentioned this pull request Nov 5, 2019
Merged
@abbeyhrt abbeyhrt mentioned this pull request Nov 5, 2019
Closed
asudoh added a commit that referenced this pull request Nov 9, 2019
@asudoh
fix(code-snippet): fix tooltip position (#4559)
53eedcb 
Refs #4517.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aagonzales aagonzales aagonzales approved these changes

@emyarod emyarod emyarod approved these changes

@jnm2377 jnm2377 Awaiting requested review from jnm2377

@jillianhowarth jillianhowarth Awaiting requested review from jillianhowarth

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Copy button] Tooltip style wrong, icon wrong
3 participants
@asudoh @aagonzales @emyarod