chore(project): update format:diff ignore pattern #4409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
FYI @abbeyhrt, I think you might have been running into this |
|
Oh nice, thanks for looking into this! Should I wait for the to be merged before merging the endgame guide update? |
|
@abbeyhrt I'm up for whatever ends up getting merged in first 👍 No harm either way |
|
Deploy preview for the-carbon-components ready! Built with commit 6c556a6 https://deploy-preview-4409--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit 6c556a6 https://deploy-preview-4409--carbon-components-react.netlify.com |
abbeyhrt
approved these changes
Oct 21, 2019
|
Deploy preview for carbon-elements ready! Built with commit 6c556a6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates our
format:diffto includereact. Thecomponentspattern was mistakenly stopping this from occurring. Also updates failures from this change.Changelog
New
Changed
format:diffnow uses a separate ignore pattern withpackages/componentsinstead ofcomponentsRemoved