fix(code-snippet): set multi-line snippet overflow-x to auto #4360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit 273674c https://deploy-preview-4360--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements failed. Built with commit 273674c https://app.netlify.com/sites/carbon-elements/deploys/5da7d268b2fd17000798634a |
|
Deploy preview for carbon-components-react failed. Built with commit 273674c https://app.netlify.com/sites/carbon-components-react/deploys/5da7d2689d78fe0008a29c59 |
joshblack
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you click on the "expand" / "view more" button for the multi-line
CodeSnippet, it will always show a horizontal scrollbar even if there isn't any content overflowing horizontally... (you can see it in action here when you expand theCodeSnippet: http://react.carbondesignsystem.com/?path=/story/codesnippet--multi-line)This can be fixed by changing
overflow-x: scroll(aka "always show a scrollbar") tooverflow-x: auto(aka "default behavior / show a scrollbar if needed")Changelog
Changed
overflow-x: scrolltooverflow-x: autoRemoved