Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): apply text color to focussed select for firefox #4343

Merged
merged 2 commits into from
Oct 15, 2019
Merged

fix(select): apply text color to focussed select for firefox #4343

merged 2 commits into from
Oct 15, 2019

Conversation

jendowns
Copy link
Contributor

@jendowns jendowns commented Oct 15, 2019

Closes #4241

It looks like Firefox expects there to be a color set on the select:focus 😲
This style rule appears to fix the issue identified in #4241

Changelog

Changed

  • set color: $text-01 when select is focussed

Testing / Reviewing

@jendowns jendowns requested a review from a team as a code owner October 15, 2019 20:25
@ghost ghost requested review from dakahn and joshblack October 15, 2019 20:25
@netlify
Copy link

netlify bot commented Oct 15, 2019

Deploy preview for the-carbon-components ready!

Built with commit 494b2f8

https://deploy-preview-4343--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Oct 15, 2019

Deploy preview for carbon-elements ready!

Built with commit 494b2f8

https://deploy-preview-4343--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Oct 15, 2019

Deploy preview for carbon-components-react failed.

Built with commit 494b2f8

https://app.netlify.com/sites/carbon-components-react/deploys/5da62b4fc2bac80007601c80

@netlify
Copy link

netlify bot commented Oct 15, 2019

Deploy preview for the-carbon-components ready!

Built with commit 44d5a2b

https://deploy-preview-4343--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Oct 15, 2019

Deploy preview for carbon-components-react ready!

Built with commit 44d5a2b

https://deploy-preview-4343--carbon-components-react.netlify.com

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @jendowns!

@netlify
Copy link

netlify bot commented Oct 15, 2019

Deploy preview for carbon-elements failed.

Built with commit 44d5a2b

https://app.netlify.com/sites/carbon-elements/deploys/5da62bb2c4ba5f0009c5c679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Select] selected option is unreadable for dark-themed UIs in Firefox
3 participants