-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(select): apply text color to focussed select for firefox #4343
fix(select): apply text color to focussed select for firefox #4343
Conversation
Deploy preview for the-carbon-components ready! Built with commit 494b2f8 https://deploy-preview-4343--the-carbon-components.netlify.com |
Deploy preview for carbon-elements ready! Built with commit 494b2f8 |
Deploy preview for carbon-components-react failed. Built with commit 494b2f8 https://app.netlify.com/sites/carbon-components-react/deploys/5da62b4fc2bac80007601c80 |
Deploy preview for the-carbon-components ready! Built with commit 44d5a2b https://deploy-preview-4343--the-carbon-components.netlify.com |
Deploy preview for carbon-components-react ready! Built with commit 44d5a2b https://deploy-preview-4343--carbon-components-react.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 - Thanks @jendowns!
Deploy preview for carbon-elements failed. Built with commit 44d5a2b https://app.netlify.com/sites/carbon-elements/deploys/5da62bb2c4ba5f0009c5c679 |
Closes #4241
It looks like Firefox expects there to be a
color
set on theselect:focus
😲This style rule appears to fix the issue identified in #4241
Changelog
Changed
color: $text-01
whenselect
is focussedTesting / Reviewing
carbon-components-react
deployment in Firefox: https://deploy-preview-4343--the-carbon-components.netlify.comg100
Select
component and see that the select option text color stays white (and readable)