Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sketch): update based on theme changes #4274

Merged
merged 4 commits into from
Oct 9, 2019
Merged

fix(sketch): update based on theme changes #4274

merged 4 commits into from
Oct 9, 2019

Conversation

joshblack
Copy link
Contributor

Update sketch plugin based on theme changes

Changelog

New

Changed

  • Only sync color styles for themes
  • Make sure yellow-30 is used instead of yellow-20 for yellow in colors

Removed

@joshblack
fix(sketch): update based on theme changes
a8ba9c8 
- Only sync color styles for themes
- Make sure yellow-30 is used instead of yellow-20 for yellow in colors
@joshblack joshblack requested a review from laurenmrice October 9, 2019 17:25
@joshblack joshblack requested a review from a team as a code owner October 9, 2019 17:25
@ghost ghost requested review from abbeyhrt and dakahn October 9, 2019 17:25
@joshblack @abbeyhrt
Update packages/sketch/src/sharedStyles/themes.js
eecfd13 
Co-Authored-By: Abbey Hart <abbeyhrt@gmail.com>
laurenmrice
laurenmrice approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@netlify
Copy link

netlify bot commented Oct 9, 2019

Deploy preview for the-carbon-components ready!

Built with commit a8ba9c8

https://deploy-preview-4274--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Oct 9, 2019

Deploy preview for carbon-elements ready!

Built with commit a8ba9c8

https://deploy-preview-4274--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Oct 9, 2019

Deploy preview for carbon-components-react failed.

Built with commit a8ba9c8

https://app.netlify.com/sites/carbon-components-react/deploys/5d9e180419b8f400076adfe2

@netlify
Copy link

netlify bot commented Oct 9, 2019

Deploy preview for carbon-elements ready!

Built with commit eecfd13

https://deploy-preview-4274--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Oct 9, 2019

Deploy preview for carbon-components-react failed.

Built with commit de2c6fd

https://app.netlify.com/sites/carbon-components-react/deploys/5d9e1c18c43bdd000bd0ad1d

@netlify
Copy link

netlify bot commented Oct 9, 2019

Deploy preview for the-carbon-components ready!

Built with commit b37d62f

https://deploy-preview-4274--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Oct 9, 2019

Deploy preview for carbon-elements ready!

Built with commit b37d62f

https://deploy-preview-4274--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Oct 9, 2019

Deploy preview for carbon-components-react failed.

Built with commit b37d62f

https://app.netlify.com/sites/carbon-components-react/deploys/5d9e1e6b8fd33e000748388c

@joshblack joshblack merged commit 7d7eedd into carbon-design-system:master Oct 9, 2019
@joshblack joshblack deleted the fix/update-sketch-with-theme-changes branch October 9, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbeyhrt abbeyhrt abbeyhrt left review comments

@laurenmrice laurenmrice laurenmrice approved these changes

@dakahn dakahn dakahn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshblack @abbeyhrt @dakahn @laurenmrice