fix(accordion): change skeleton buttons to spans for a11y #4273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit f99ba3d https://deploy-preview-4273--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit f99ba3d |
|
Deploy preview for carbon-components-react ready! Built with commit f99ba3d https://deploy-preview-4273--carbon-components-react.netlify.com |
joshblack
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4177
Proposal to change the
buttonelements inside theAccordionSkeletonandAccordionSkeletonItemcomponents intospans. My reasoning: since these headings and items in the skeleton component are non-interactive, there shouldn't be a reason to mark them asbuttonelements. This change would also remove the DAP violations.Changelog
Changed
buttonelements intospanelementsTesting / Reviewing
Open the React storybook deployment, view the
AccordionSkeleton, and run the latest DAP ruleset (Sept 2019).