Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tooltip): add display name for storybook #4267

Merged
merged 2 commits into from
Oct 9, 2019
Merged

docs(tooltip): add display name for storybook #4267

merged 2 commits into from
Oct 9, 2019

Conversation

jendowns
Copy link
Contributor

@jendowns jendowns commented Oct 8, 2019

Right now if you look at the Tooltip stories, click on the blue "show info" button, and look at the "Story source" section, you'll see [object Object] in the source: http://react.carbondesignsystem.com/?path=/story/tooltip--default-bottom

Screen Shot 2019-10-08 at 4 42 45 PM

By adding a display name, you can make it say show the component's name Tooltip instead.

Changelog

New

  • add a display name for Tooltip in storybook

@jendowns jendowns requested a review from a team as a code owner October 8, 2019 21:45
@ghost ghost requested review from emyarod and jnm2377 October 8, 2019 21:45
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @jendowns!

@netlify
Copy link

netlify bot commented Oct 8, 2019

Deploy preview for carbon-elements ready!

Built with commit 91887d7

https://deploy-preview-4267--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Oct 8, 2019

Deploy preview for carbon-components-react failed.

Built with commit 91887d7

https://app.netlify.com/sites/carbon-components-react/deploys/5d9d78c6f8b7ca00084224b0

@netlify
Copy link

netlify bot commented Oct 8, 2019

Deploy preview for the-carbon-components ready!

Built with commit 91887d7

https://deploy-preview-4267--the-carbon-components.netlify.com

@asudoh asudoh merged commit 7fe673a into carbon-design-system:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants