Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Slider): use lighter hue for focused and active slider colors #4214

Merged
merged 4 commits into from
Oct 9, 2019

Conversation

AlexanderLyon
Copy link
Contributor

Closes #4203

Changed the colors used for focused / active slider from $interactive-01 to $interactive-04 for better visibility on Gray 90 and Gray 100

Changelog

Changed

  • _slider.scss

image

@AlexanderLyon AlexanderLyon requested a review from a team as a code owner October 4, 2019 01:24
@ghost ghost requested review from abbeyhrt and jnm2377 October 4, 2019 01:24
@AlexanderLyon
Copy link
Contributor Author

@laurenmrice 👆

@netlify
Copy link

netlify bot commented Oct 4, 2019

Deploy preview for the-carbon-components ready!

Built with commit 8c41001

https://deploy-preview-4214--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Oct 4, 2019

Deploy preview for carbon-components-react ready!

Built with commit 8c41001

https://deploy-preview-4214--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Oct 4, 2019

Deploy preview for carbon-elements ready!

Built with commit 8c41001

https://deploy-preview-4214--carbon-elements.netlify.com

Copy link
Contributor

@jnm2377 jnm2377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for this! 🎉

Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for contributing! 🎉

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks ! 🎉

@asudoh asudoh merged commit e2239db into carbon-design-system:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[slider] Gray 90 and Gray 100 bug with interactive color
6 participants