Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(button): removed outline on disabled tertiary and ghost_buttons #4165

Merged
merged 3 commits into from
Oct 8, 2019
Merged

fix(button): removed outline on disabled tertiary and ghost_buttons #4165

merged 3 commits into from
Oct 8, 2019

Conversation

ankitious
Copy link
Contributor

@ankitious ankitious commented Oct 2, 2019 •
edited by emyarod
Loading

Closes #3944

Regression bug: Disabled button's hover state #3944

Changelog

Changed

  • Added outline:none for ghost and tertiary disabled buttons

Testing / Reviewing

  • Go to ghost and tertiary buttons disabled button.
  • Hover over them.
  • Previously outline were coming which was unnecessary for disabled buttons.

@ankitious ankitious requested a review from a team as a code owner October 2, 2019 08:58
@ghost ghost requested review from abbeyhrt and jnm2377 October 2, 2019 08:58
@netlify
Copy link

netlify bot commented Oct 2, 2019 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit 0ac8080

https://deploy-preview-4165--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Oct 2, 2019 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 0ac8080

https://deploy-preview-4165--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Oct 2, 2019 •
edited
Loading

Deploy preview for carbon-components-react failed.

Built with commit 0ac8080

https://app.netlify.com/sites/carbon-components-react/deploys/5d9d098f6f10f40007e37029

emyarod
emyarod approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

aagonzales
aagonzales approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Looks good!

jnm2377
jnm2377 approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@jnm2377 jnm2377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution! We currently have a code freeze until next week, but will merge this in after code freeze 🎉

@joshblack joshblack merged commit e973965 into carbon-design-system:master Oct 8, 2019
@abbeyhrt abbeyhrt mentioned this pull request Oct 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnm2377 jnm2377 jnm2377 approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

@aagonzales aagonzales aagonzales approved these changes

@emyarod emyarod emyarod approved these changes

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression bug: Disabled button's hover state
6 participants
@ankitious @joshblack @emyarod @aagonzales @abbeyhrt @jnm2377