fix(accordion): top align accordion headings #4125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit f9edb3d https://deploy-preview-4125--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit f9edb3d |
|
Deploy preview for carbon-components-react ready! Built with commit f9edb3d https://deploy-preview-4125--carbon-components-react.netlify.com |
abbeyhrt
approved these changes
Sep 27, 2019
jnm2377
approved these changes
Sep 27, 2019
jillianhowarth
approved these changes
Sep 27, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4051
refs IBM-Design/idr#98
This PR changes the accordion heading chevron alignment rules so that it is top aligned rather than center aligned. The
$accordion-arrow-margintoken is modified order to keep the chevron centered when the accordion heading is one line long. The React Accordion storybook example is also modified to follow the design guidelines (headings should remain 14px large)Changelog
Changed
$accordion-arrow-margintoken (margin-toprule)Testing / Reviewing
Ensure the accordion looks correct with multiline headings (this can be done by editing storybook knobs or directly changing the content in devtools directly)