-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(combobox): controlled combobox clear #18041
base: main
Are you sure you want to change the base?
fix(combobox): controlled combobox clear #18041
Conversation
* update the way onChange is called in comboBox to prevent unwanted calls * add unit test cases for controlled combobox managed by parent component
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18041 +/- ##
=======================================
Coverage 82.14% 82.15%
=======================================
Files 404 404
Lines 14117 14121 +4
Branches 4434 4442 +8
=======================================
+ Hits 11597 11601 +4
+ Misses 2359 2358 -1
- Partials 161 162 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for taking a second look at this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* fix withLayer proptypes * add required onChange prop to examples in ComboBox.mdx
Closes #18027
Testing / Reviewing